Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing fields to add/edit form #1502

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

trillium
Copy link
Member

@trillium trillium commented Sep 7, 2023

Fixes #1501

What changes did you make and why did you make them ?

the fields from the project model hflaWebsiteUrl, githubIdentifier were not being added to a project on creation and on edit. The fields accepted data but didn't store the data in the db.

  • Updated ProjcetApiService to include hflaWebsiteUrl, githubIdentifier in the db call
  • Updated EditProject to incldue hflaWebsiteUrl, githubIdentifier in the initial set state

hflaWebsiteUrl, githubIdentifier
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Spiteless-ts.1501 development
git pull https://github.com/Spiteless/VRMS.git ts.1501

@trillium trillium merged commit 49d8136 into hackforla:development Sep 7, 2023
5 checks passed
@trillium trillium deleted the ts.1501 branch September 7, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update projectToEdit to have all correct fields for newProject and editProject form
2 participants